read dataTypeID and tableID as unsigned uint #3347
Conversation
this is causing issues in other projects, like sequelize/sequelize#15466
There was a problem hiding this comment.
I wonder if any other things documented as IntN are secretly unsigned?
|
@charmander I made a request for the docs to be updated reflecting what fields are signed and which are unsigned. Can we merge this one, and when the request goes through and the docs are updated we can open another issue here to make the changes? |
|
@charmander,is this ok to be merged? |
|
Only brianc can publish a new version of the package, so most times, at best it doesn’t really help anything for me to merge a PR (and at worst I missed something in review, so may as well wait for the chance to get a second review anyway). |
|
Ok. The request I made for documentation doesn't seem like it's going anywhere, and I found someone made the same request in 2020 here: https://www.postgresql.org/message-id/159173854100.661.1819403154632752741%40wrigleys.postgresql.org, so it doesn't seem like anything is going to change. |
The oids are supposed to be unsigned ints, according to the docs.
This causes issues with oids larger than 2^31 since they become negative.
This is causing issues in other projects, like sequelize/sequelize#15466 (comment)